Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache the database encoding #485

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Don't cache the database encoding #485

merged 1 commit into from
Jan 24, 2024

Conversation

tenderlove
Copy link
Member

Database encoding can be changed, and we don't want to intercept all queries just to check if someone changed the encoding. This commit removes the encoding cache. If applications find that they are querying the database encoding frequently, they should cache the return value of this method themselves

Database encoding can be changed, and we don't want to intercept all
queries just to check if someone changed the encoding. This commit
removes the encoding cache. If applications find that they are querying
the database encoding frequently, they should cache the return value of
this method themselves
@tenderlove tenderlove merged commit f5f6859 into main Jan 24, 2024
101 checks passed
@tenderlove tenderlove deleted the no-encoding-cache branch January 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant